| To: | Manuel Lauss <manuel.lauss@googlemail.com> |
|---|---|
| Subject: | Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code. |
| From: | Sergei Shtylyov <sshtylyov@mvista.com> |
| Date: | Tue, 09 Mar 2010 14:51:42 +0300 |
| Cc: | Linux-MIPS <linux-mips@linux-mips.org>, Manuel Lauss <manuel.lauss@gmail.com> |
| In-reply-to: | <f861ec6f1003090345n53570102je68aef14e8b3f3fb@mail.gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1268076181-29642-1-git-send-email-manuel.lauss@gmail.com> <1268076181-29642-3-git-send-email-manuel.lauss@gmail.com> <4B963210.7030906@ru.mvista.com> <f861ec6f1003090345n53570102je68aef14e8b3f3fb@mail.gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.23 (Windows/20090812) |
Manuel Lauss wrote: Where it really belongs to.I disagree (again). SoC platform devices dont belong with the board code.Figured as much. However with additional boards the #ifdef mess in common/platform.c is only going to get worse. MUCH worse. We could probably eliminate the board #ifdef in platfrom.c by not supplying the platfrom data for MMC1. Just look at the au1000-eth platform data situation! I have these platform devices on Au1200/Au1300 even thought they don't have a built-in MAC. Need to add the SoC type checks then when registering the devices. Or at least the #ifdef's. :-) The board which uses the device should register it. Contrarywise, the SoC that has the devices, should register them. But, consider the patch withdrawn. Thanks. Manuel WBR, Sergei |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code., Manuel Lauss |
|---|---|
| Next by Date: | Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code., Manuel Lauss |
| Previous by Thread: | Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code., Manuel Lauss |
| Next by Thread: | Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code., Manuel Lauss |
| Indexes: | [Date] [Thread] [Top] [All Lists] |