Re: [PATCH] MIPS: Octeon: Register EEPROM device on the I2C bus

[Yang Shi <yang.shi@windriver.com>]

Jean Delvare 写道:
> Hi Michael,
>
> On Fri, 05 Mar 2010 12:17:14 +0100, Michael Lawnick wrote:
>   
> > Jean Delvare said the following:
> >     
> > > Well, what EEPROM type do you have exactly? 24c64 is for 64 kbit (8
> > > kByte) EEPROMs using 16-bit addressing. You must use the correct type,
> > > otherwise the at24 driver will misbehave. I am a little surprised
> > > because originally you went for "eeprom" which is not compatible with
> > > "24c64" (8-bit vs. 16-bit addressing).
> > >       
> > Furthermore this brings up another issue:
> > 0x50 typically is SPD-eeprom (DDR initialisation). Corrupting the
> > contents might make your board unbootable - and using a 16bit driver
> > instead of an 8-bit one can corrupt your contents already on
> > (positioned) reading!
> >     
> This is totally correct, but better said loud to the list and the
> original poster than only privately to me ;)
>   
Thanks a lot to point out this.

I double checked the manual, the eeprom is SPD of the DIMMs.

I will rework my patch, then send V2 soon.

Regards,
Yang