linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_res

To: Yang Shi <yang.shi@windriver.com>, ralf@linux-mips.org
Subject: Re: [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 03 Mar 2010 10:25:49 -0800
Cc: f.fainelli@gmail.com, linux-mips@linux-mips.org
In-reply-to: <50e36e8549769a26986f99a23772d23fd039c230.1267604875.git.yang.shi@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1267605801-5305-1-git-send-email-yang.shi@windriver.com> <fd8fb199609e60a5b6c10e2073976a3f6b599109.1267604875.git.yang.shi@windriver.com> <50e36e8549769a26986f99a23772d23fd039c230.1267604875.git.yang.shi@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100225 Fedora/3.0.2-1.fc12 Thunderbird/3.0.2
On 03/03/2010 12:43 AM, Yang Shi wrote:
In Octeon's setup.c, octeon_reserve32_memory is defined, so remove the
redundant extern declaration of this variable.

Signed-off-by: Yang Shi<yang.shi@windriver.com>

Acked-by: David Daney <ddaney@caviumnetworks.com>

This looks good to me.  Thanks,
David Daney

---
  arch/mips/cavium-octeon/setup.c |    3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
index 4eaa35f..8309d68 100644
--- a/arch/mips/cavium-octeon/setup.c
+++ b/arch/mips/cavium-octeon/setup.c
@@ -45,9 +45,6 @@ extern struct plat_smp_ops octeon_smp_ops;
  extern void pci_console_init(const char *arg);
  #endif

-#ifdef CONFIG_CAVIUM_RESERVE32
-extern uint64_t octeon_reserve32_memory;
-#endif
  static unsigned long long MAX_MEMORY = 512ull<<  20;

  struct octeon_boot_descriptor *octeon_boot_desc_ptr;


<Prev in Thread] Current Thread [Next in Thread>