linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header

To: Yang Shi <yang.shi@windriver.com>
Subject: Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 03 Mar 2010 10:24:11 -0800
Cc: ralf@linux-mips.org, f.fainelli@gmail.com, linux-mips@linux-mips.org
In-reply-to: <004eb64c73b3bcec90612663598ada4cf678f236.1267604875.git.yang.shi@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1267605801-5305-1-git-send-email-yang.shi@windriver.com> <fd8fb199609e60a5b6c10e2073976a3f6b599109.1267604875.git.yang.shi@windriver.com> <50e36e8549769a26986f99a23772d23fd039c230.1267604875.git.yang.shi@windriver.com> <004eb64c73b3bcec90612663598ada4cf678f236.1267604875.git.yang.shi@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100225 Fedora/3.0.2-1.fc12 Thunderbird/3.0.2
On 03/03/2010 12:43 AM, Yang Shi wrote:
Octeon's setup.c uses add_wired_entry, but it is not declared
anywhere. Copy add_wired_entry decralation from pgtable-32.h to
pgtable-64.h and include asm/pgtable.h into Octeon's setup.c.

Signed-off-by: Yang Shi<yang.shi@windriver.com>

NAK!

We are removing the use of add_wired_entry(), so adding a declaration will not be necessary.

David Daney


---
  arch/mips/cavium-octeon/setup.c    |    1 +
  arch/mips/include/asm/pgtable-64.h |    6 ++++++
  2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
index 8309d68..d63b8e6 100644
--- a/arch/mips/cavium-octeon/setup.c
+++ b/arch/mips/cavium-octeon/setup.c
@@ -30,6 +30,7 @@
  #include<asm/bootinfo.h>
  #include<asm/sections.h>
  #include<asm/time.h>
+#include<asm/pgtable.h>

  #include<asm/octeon/octeon.h>

diff --git a/arch/mips/include/asm/pgtable-64.h 
b/arch/mips/include/asm/pgtable-64.h
index 26dc69d..85ee34d 100644
--- a/arch/mips/include/asm/pgtable-64.h
+++ b/arch/mips/include/asm/pgtable-64.h
@@ -23,6 +23,12 @@
  #endif

  /*
+ * - add_wired_entry() add a fixed TLB entry, and move wired register
+ */
+extern void add_wired_entry(unsigned long entrylo0, unsigned long entrylo1,
+                              unsigned long entryhi, unsigned long pagemask);
+
+/*
   * Each address space has 2 4K pages as its page directory, giving 1024
   * (== PTRS_PER_PGD) 8 byte pointers to pmd tables. Each pmd table is a
   * single 4K page, giving 512 (== PTRS_PER_PMD) 8 byte pointers to page


<Prev in Thread] Current Thread [Next in Thread>