linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter

To: Yang Shi <yang.shi@windriver.com>
Subject: Re: [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 03 Mar 2010 09:53:01 -0800
Cc: ralf@linux-mips.org, f.fainelli@gmail.com, linux-mips@linux-mips.org
In-reply-to: <fd8fb199609e60a5b6c10e2073976a3f6b599109.1267604875.git.yang.shi@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1267605801-5305-1-git-send-email-yang.shi@windriver.com> <fd8fb199609e60a5b6c10e2073976a3f6b599109.1267604875.git.yang.shi@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100225 Fedora/3.0.2-1.fc12 Thunderbird/3.0.2
On 03/03/2010 12:43 AM, Yang Shi wrote:
Now, on_each_cpu just need three parameters, but the on_each_cpu
still uses four parameters in Octeon's setup.c. So, remove the
superfluous parameter.

Signed-off-by: Yang Shi<yang.shi@windriver.com>


NAK!  We are removing CONFIG_CAVIUM_RESERVE32_USE_WIRED_TLB completely.

I will send the removal patch soon.

David Daney

---
  arch/mips/cavium-octeon/setup.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
index b321d3b..4eaa35f 100644
--- a/arch/mips/cavium-octeon/setup.c
+++ b/arch/mips/cavium-octeon/setup.c
@@ -230,7 +230,7 @@ static void octeon_hal_setup_per_cpu_reserved32(void 
*unused)
  void octeon_hal_setup_reserved32(void)
  {
  #ifdef CONFIG_CAVIUM_RESERVE32_USE_WIRED_TLB
-       on_each_cpu(octeon_hal_setup_per_cpu_reserved32, NULL, 0, 1);
+       on_each_cpu(octeon_hal_setup_per_cpu_reserved32, NULL, 1);
  #endif
  }



<Prev in Thread] Current Thread [Next in Thread>