| To: | David Daney <ddaney@caviumnetworks.com> |
|---|---|
| Subject: | Re: [PATCH] Make mips-linux signal frame unwinding more robust. |
| From: | Daniel Jacobowitz <dan@codesourcery.com> |
| Date: | Fri, 26 Feb 2010 15:50:17 -0500 |
| Cc: | gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>, "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org> |
| In-reply-to: | <4B881151.9070300@caviumnetworks.com> |
| Mail-followup-to: | David Daney <ddaney@caviumnetworks.com>, gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>, "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <4B82CEC4.2010607@caviumnetworks.com> <20100225174739.GA2851@adacore.com> <4B86C5EB.6090303@caviumnetworks.com> <4B881151.9070300@caviumnetworks.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Fri, Feb 26, 2010 at 10:22:09AM -0800, David Daney wrote: > The current signal frame unwinding code in mips-linux-tdep.c assumes > a constant offset from the signal return trampoline to the signal > frame. The assumption does not hold for all kernels. Specifically > those that have to be compiled with ICACHE_REFILLS_WORKAROUND_WAR > set (SGI O2 for example). In the near future, it is likely that the > assumption will cease to hold universally, as we are attempting to > move the signal return trampoline off the stack entirely. It's funny, I thought I'd already taught GDB about the WAR workaround, but there's no hint of it. Your patch looks good to me. > OK to commit? > > How about on the 7.1 branch? OK both. -- Daniel Jacobowitz CodeSourcery |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: Alchemy: defconfig updates, Ralf Baechle |
|---|---|
| Next by Date: | [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup, Andrea Gelmini |
| Previous by Thread: | Re: [PATCH] Make mips-linux signal frame unwinding more robust., David Daney |
| Next by Thread: | [PATCH 0/2] MIPS: Alchemy: various build fixes, Manuel Lauss |
| Indexes: | [Date] [Thread] [Top] [All Lists] |