linux-mips
[Top] [All Lists]

Re: [MIPS] Cobalt: convert legacy port addresses to GT-64111 bus address

To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [MIPS] Cobalt: convert legacy port addresses to GT-64111 bus addresses
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 25 Feb 2010 15:38:04 +0100
Cc: Yoichi Yuasa <yuasa@linux-mips.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, linux-mips@linux-mips.org
In-reply-to: <201002241353.28391.bjorn.helgaas@hp.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <201002241353.28391.bjorn.helgaas@hp.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Wed, Feb 24, 2010 at 01:53:27PM -0700, Bjorn Helgaas wrote:

> The GT-64111 PCI host bridge has no address translation mechanism, so
> it can't generate legacy port accesses.  This quirk fixes legacy device
> port resources to contain the bus addresses actually generated by the
> GT-64111.
> 
> I think this is the approach Ben Herrenschmidt suggested long ago:
>     http://marc.info/?l=linux-kernel&m=119733290624544&w=2
> 
> This allows us to remove the IORESOURCE_PCI_FIXED hack from
> pcibios_fixup_device_resources(), which converts bus addresses to CPU
> addresses.  IORESOURCE_PCI_FIXED denotes resources that can't be moved;
> it has nothing to do with converting bus to CPU addresses.

Thanks, queued for 2.6.34.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>