linux-mips
[Top] [All Lists]

Re: udelay() too slow by a factor of 2 on Cavium chips

To: Brian Daniels <bdaniels@ciena.com>
Subject: Re: udelay() too slow by a factor of 2 on Cavium chips
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 24 Feb 2010 17:45:25 -0800
Cc: linux-mips@linux-mips.org
In-reply-to: <4B85D445.2090700@ciena.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4B85D445.2090700@ciena.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1
On 02/24/2010 05:37 PM, Brian Daniels wrote:
We've noticed that udelay() and related functions are too slow by a
factor of 2 on Cavium CPUs. I did some investigation and it seems to be
related to the fact that Cavium is the only MIPS CPU family that has
ARCH_HAS_READ_CURRENT_TIMER defined to use its hardware cycle counter
(CvmCount) to calibrate loops-per-jiffy. Since udelay() uses lpj to
calculate the number of loops to wait in __delay() it is affected by the
lpj calibration.

On a 600MHz Cavium system running 2.6.33-rc8 with HZ=250 the lpj is
2404728. This results in udelay() passing 601 to __delay() for a 1us
delay which would work if __delay took 1 cycle per loop however it takes
2 cycles giving a delay of 2us.

It seems the easiest way to fix the problem would be to remove the
definition of ARCH_HAS_READ_CURRENT_TIMER for Cavium which would use the
same lpj calibration delay loop as other MIPS CPUs. With this change on
the same 600MHz system lpj is 1196032 which results in udelay() passing
299 to __delay() which would yield close to the desired 1us delay.

I'm not sure what all of the implications would be of effectively
halving lpj on Cavium CPUs or what the rationale was for defining
ARCH_HAS_READ_CURRENT_TIMER for Cavium CPUs in the first place. I'm
hoping someone more informed can take a look at it and propose a fix if
what I've proposed isn't good enough.


Thanks for the report.  I will look at it.

David Daney

<Prev in Thread] Current Thread [Next in Thread>