Re: [PATCH 4/4] Staging: Octeon: Free transmit SKBs in a timely manner.

[Eric Dumazet <eric.dumazet@gmail.com>]

Le lundi 15 février 2010 à 12:13 -0800, David Daney a écrit :
> If we wait for the once-per-second cleanup to free transmit SKBs,
> sockets with small transmit buffer sizes might spend most of their
> time blocked waiting for the cleanup.
> 
> Normally we do a cleanup for each transmitted packet.  We add a
> watchdog type timer so that we also schedule a timeout for 150uS after
> a packet is transmitted.  The watchdog is reset for each transmitted
> packet, so for high packet rates, it never expires.  At these high
> rates, the cleanups are done for each packet so the extra watchdog
> initiated cleanups are not needed.

s/needed/fired/

Hmm, but re-arming a timer for each transmited packet must have a cost ?

> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>

Is there any particular reason periodic is spelled preiodic ?

> ---
>  }
>  
> -static void cvm_oct_tx_clean_worker(struct work_struct *work)
> +static void cvm_oct_preiodic_worker(struct work_struct *work)
>  {



> -                     INIT_DELAYED_WORK(&priv->tx_clean_work,
> -                                       cvm_oct_tx_clean_worker);
> -
> +                     INIT_DELAYED_WORK(&priv->port_periodic_work,
> +                                       cvm_oct_preiodic_worker);