linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Don't probe reserved EntryHi bits.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Don't probe reserved EntryHi bits.
From: Guenter Roeck <guenter.roeck@ericsson.com>
Date: Mon, 8 Feb 2010 12:36:28 -0800
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>
In-reply-to: <1265660820-5418-1-git-send-email-ddaney@caviumnetworks.com>
Organization: Ericsson
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1265660820-5418-1-git-send-email-ddaney@caviumnetworks.com>
Reply-to: guenter.roeck@ericsson.com
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2010-02-08 at 15:27 -0500, David Daney wrote:
> The patch that adds cpu_probe_vmbits is erroneously writing to
> reserved bit 12.  Since we are really only probing high bits, don't
> write this bit with a one.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> CC: Guenter Roeck <guenter.roeck@ericsson.com>

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>

> ---
>  arch/mips/kernel/cpu-probe.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
> index 2ff5f64..9ea5ca8 100644
> --- a/arch/mips/kernel/cpu-probe.c
> +++ b/arch/mips/kernel/cpu-probe.c
> @@ -287,9 +287,9 @@ static inline int __cpu_has_fpu(void)
>  static inline void cpu_probe_vmbits(struct cpuinfo_mips *c)
>  {
>  #ifdef __NEED_VMBITS_PROBE
> -     write_c0_entryhi(0x3ffffffffffff000ULL);
> +     write_c0_entryhi(0x3fffffffffffe000ULL);
>       back_to_back_c0_hazard();
> -     c->vmbits = fls64(read_c0_entryhi() & 0x3ffffffffffff000ULL);
> +     c->vmbits = fls64(read_c0_entryhi() & 0x3fffffffffffe000ULL);
>  #endif
>  }
>  


<Prev in Thread] Current Thread [Next in Thread>