linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: add 8250/16550 serial early printk driver

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 1/2] MIPS: add 8250/16550 serial early printk driver
From: Yoichi Yuasa <yuasa@linux-mips.org>
Date: Mon, 8 Feb 2010 20:54:07 +0900
Cc: yuasa@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:message-id:in-reply-to:references:x-mailer:mime-version :content-type:content-transfer-encoding; bh=Kt/1Xt+dPYiWhX16Xi4cZAJM1DLCu/XDPZKG7UdKPNA=; b=L+ltBTNT9g5B8SmusNvJVhsvYaOtaSf9o61us0P5abdVQ1fv61nA4BzCQHUSbXmorU eoh2KkukWveLwWbwNXxLGrPn224oa1xxaEHSYzygHuqfquzyRlKH4EVcVmyE8FRhB/vh TCl5mEP2SmHgD9AU6gij8kuSpXAT8p5yb8+QY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; b=VVf1vGBEb06e2qWmawiPRCsIYIvbs2dSN30BOxt6pg/zEft91p80aamZmJlY+G3PIl 07r7IF+CRb1WW4V9bNOKOsFL8/HdNRyZxSBRZDSwgScPyL+zHg+J9eiyAgJ5xqo+dPyj kWBG1cQ9njrGSzFqWLpLNl39QNsqYPlOt9EZA=
In-reply-to: <4B6FE030.1080708@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20100205232857.eb65967f.yuasa@linux-mips.org> <4B6FE030.1080708@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
Hello Sergei,

On Mon, 08 Feb 2010 12:58:08 +0300
Sergei Shtylyov <sshtylyov@mvista.com> wrote:

> Hello.
> 
> Yoichi Yuasa wrote:
> 
> > Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> >   
> [...]
> > +config EARLY_PRINTK_8250
> > +   bool "8250/16550 and compatible serial early printk driver"
> > +   depends on EARLY_PRINTK
> > +   default n
> > +   help
> > +     If you say Y here, it will be possible to use a 8250/16550 serial
> > +     port as the boot console.
> > +   
> >   
> 
>    Tab not needed here.

thanks

> > diff --git a/arch/mips/kernel/early_printk_8250.c 
> > b/arch/mips/kernel/early_printk_8250.c
> > new file mode 100644
> > index 0000000..6faf8fd
> > --- /dev/null
> > +++ b/arch/mips/kernel/early_printk_8250.c
[...]
> > +static unsigned long serial8250_base;
> > +static unsigned int serial8250_reg_shift;
> > +static unsigned int serial8250_tx_timeout;
> > +
> > +void setup_8250_early_printk_port(unsigned long base, unsigned int 
> > reg_shift,
> > +                             unsigned int timeout)
> > +{
> > +   serial8250_base = base;
> >   
> 
>    Why not declare 'serial8250_base' as 'void __iomem *' and only cast 
> once, here?

You're right. I'll update it.

Thanks,

Yoichi

<Prev in Thread] Current Thread [Next in Thread>