linux-mips
[Top] [All Lists]

Re: [PATCH urgent] MIPS: Fixup of the r4k timer

To: Shane McDonald <mcdonald.shane@gmail.com>
Subject: Re: [PATCH urgent] MIPS: Fixup of the r4k timer
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 3 Feb 2010 02:29:34 +0100
Cc: Wu Zhangjin <wuzhangjin@gmail.com>, David VomLehn <dvomlehn@cisco.com>, mbizon@freebox.fr, linux-mips@linux-mips.org
In-reply-to: <b2b2f2321002011903m7a090481m52d84a664beb5468@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1265015455-32553-1-git-send-email-wuzhangjin@gmail.com> <b2b2f2321002011903m7a090481m52d84a664beb5468@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, Feb 01, 2010 at 09:03:10PM -0600, Shane McDonald wrote:

> On Mon, Feb 1, 2010 at 3:10 AM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> >
> > From: Wu Zhangjin <wuzhangjin@gmail.com>
> >
> > As reported by Maxime Bizon, the commit "MIPS: PowerTV: Fix support for
> > timer interrupts with > 64 external IRQs" have broken the r4k timer
> > since it didn't initialize the cp0_compare_irq_shift variable used in
> > c0_compare_int_pending() on the architectures whose cpu_has_mips_r2 is
> > false.
> >
> > This patch fixes it via initializing the cp0_compare_irq_shift as the
> > cp0_compare_irq used in the old c0_compare_int_pending().
> >
> > Reported-by: Maxime Bizon <mbizon@freebox.fr>
> > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> When applied to 2.6.33-rc6, this patch fixes the problem on my
> RM7035C-based system.
> 
> Tested-by: Shane McDonald <mcdonald.shane@gmail.com>

Thanks folks, applied.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>