| To: | Wolfram Sang <w.sang@pengutronix.de> |
|---|---|
| Subject: | Re: [PATCH 2/2] bcm63xx_uart: allow more than one uart to be registered. |
| From: | Greg KH <greg@kroah.com> |
| Date: | Mon, 1 Feb 2010 14:29:19 -0800 |
| Cc: | Maxime Bizon <mbizon@freebox.fr>, Greg Kroah-Hartman <gregkh@suse.de>, linux-serial@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| In-reply-to: | <20100130182343.GA6971@pengutronix.de> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1264873377-28479-1-git-send-email-mbizon@freebox.fr> <1264873377-28479-3-git-send-email-mbizon@freebox.fr> <20100130182343.GA6971@pengutronix.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Sat, Jan 30, 2010 at 07:23:43PM +0100, Wolfram Sang wrote:
> On Sat, Jan 30, 2010 at 06:42:57PM +0100, Maxime Bizon wrote:
> > The bcm6358 CPU has two uarts, make it possible to use the second one.
> >
> > Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> > ---
> > drivers/serial/bcm63xx_uart.c | 5 +++--
> > 1 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/serial/bcm63xx_uart.c b/drivers/serial/bcm63xx_uart.c
> > index f78ede8..6ab959a 100644
> > --- a/drivers/serial/bcm63xx_uart.c
> > +++ b/drivers/serial/bcm63xx_uart.c
> > @@ -35,7 +35,7 @@
> > #include <bcm63xx_regs.h>
> > #include <bcm63xx_io.h>
> >
> > -#define BCM63XX_NR_UARTS 1
> > +#define BCM63XX_NR_UARTS 2
> >
> > static struct uart_port ports[BCM63XX_NR_UARTS];
> >
> > @@ -784,7 +784,7 @@ static struct uart_driver bcm_uart_driver = {
> > .dev_name = "ttyS",
> > .major = TTY_MAJOR,
> > .minor = 64,
> > - .nr = 1,
> > + .nr = 2,
>
> Err, why not using the #define here?
Good idea, I've tweaked the patch to do that.
thanks,
greg k-h
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2] Virtual memory size detection for 64 bit MIPS CPUs, Guenter Roeck |
|---|---|
| Next by Date: | Re: [PATCH v2] Virtual memory size detection for 64 bit MIPS CPUs, Maciej W. Rozycki |
| Previous by Thread: | [PATCH v2] Virtual memory size detection for 64 bit MIPS CPUs, Guenter Roeck |
| Next by Thread: | [PATCH v3] Virtual memory size detection for 64 bit MIPS CPUs, Guenter Roeck |
| Indexes: | [Date] [Thread] [Top] [All Lists] |