linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] MIPS: AR7 make ar7_register_devices much more durable

To: linux-mips@linux-mips.org
Subject: Re: [PATCH 3/3] MIPS: AR7 make ar7_register_devices much more durable
From: Alexander Clouter <alex@digriz.org.uk>
Date: Mon, 1 Feb 2010 20:15:22 +0000
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <dt2h37-ch6.ln1@chipmunk.wormnet.eu> <20100201190159.GC9806@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: tin/1.9.3-20080506 ("Dalintober") (UNIX) (Linux/2.6.26-2-sparc64-smp (sparc64))
Ralf Baechle <ralf@linux-mips.org> wrote:
>
> On Sun, Jan 31, 2010 at 07:39:57PM +0000, Alexander Clouter wrote:
> 
>> MIPS: AR7 make ar7_register_devices much more durable
> 
> patches/0070-03.patch:85: space before tab in indent.
>        }
> patches/0070-03.patch:192: space before tab in indent.
>        iounmap(bootcr);
> patches/0070-03.patch:208: space before tab in indent.
>                res = platform_device_register(&ar7_wdt);
> error: patch failed: arch/mips/ar7/platform.c:529
> error: arch/mips/ar7/platform.c: patch does not apply
> 
> Grrr :-)
> 
My grovelling apologies, I do normally worship at the altar of 
checkpatch.pl however my faith was recently shattered by the acceptance 
for lines longer than 80 chars...

> I've fixed that up, also the pr_xxx changes suggested by Wu.  Queued
> for 2.6.34.
> 
I have some other code for you to rewrite if you are willing?

All this manual fixing up does makeme ponder if you are trying to avoid 
doing something else you should be doing though :)

Sorry again and also my thanks

-- 
Alexander Clouter
.sigmonster says: YOW!!  The land of the rising SONY!!


<Prev in Thread] Current Thread [Next in Thread>