linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] MIPS: AR7 whitespace hacking

To: Alexander Clouter <alex@digriz.org.uk>
Subject: Re: [PATCH 1/3] MIPS: AR7 whitespace hacking
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 1 Feb 2010 18:45:12 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1hli37-4t9.ln1@chipmunk.wormnet.eu>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <bq2h37-ch6.ln1@chipmunk.wormnet.eu> <1265005758.31984.8.camel@falcon> <1hli37-4t9.ln1@chipmunk.wormnet.eu>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Mon, Feb 01, 2010 at 10:03:45AM +0000, Alexander Clouter wrote:
> From: Alexander Clouter <alex@digriz.org.uk>
> Date:   Mon, 1 Feb 2010 10:03:45 +0000
> To: linux-mips@linux-mips.org
> Subject: Re: [PATCH 1/3] MIPS: AR7 whitespace hacking
> 
> Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> >
> >> +/*****************************************************************************
> >> + * VLYNQ Bus
> >> + 
> >> ****************************************************************************/
> > 
> > Why not simply use:
> > 
> > /* VLYNQ Bus */
> > 
> > You have deleted lots of whitespaces, but added more *.
> >
> "good enough for ARM[1]" :)
> 
> Compromise on this instead?
> ----
> /*
>  * VLYNQ Bus
>  */
> ---- 

Just did this one myself.

The patch also had a reject on the lest segment of arch/mips/ar7/prom.c.rej;
it seems that you've not created your patches against a recent version
of the -queue tree.  Either way, queued for 2.6.34.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>