| To: | mbizon@freebox.fr |
|---|---|
| Subject: | Re: [PATCH] powertv: Fix support for timer interrupts when using >64 external IRQs |
| From: | Wu Zhangjin <wuzhangjin@gmail.com> |
| Date: | Mon, 01 Feb 2010 16:47:56 +0800 |
| Cc: | David VomLehn <dvomlehn@cisco.com>, linux-mips@linux-mips.org, ralf@linux-mips.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=59ImsTZtIjmUtc5MOMHVgajKTh+tFGxPZgyZ/hFCoY4=; b=tHYDmi3w1fWJ/vPXtC39wKoFYgnOdrq6GgJydV5QqtVNxlrlhh7w4FTplMI11MmotP GYUnnXAg1uZiYKFw4tF/T+xbNBUgzdmtyRpzP7uDgTZBit/NEWzjF7TW+UcNnBO1Za/H uXlLrhUxJO5MUQO1DjJqIyvqivAUuN1l6tKjM= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=n8Cpi60LANC1qrCwOezUfWXJYjKeFrWe1UMIEuMb0nC4AoJepWJJDnSJN+srTGF60p IjOIk7UuQqCeCBsbLM7o5pyANGb6C+l86EUeVsjfvbq6arIb8Fomj57A1zdPkezRv07O JMf+QaYrIOoPzoRxH/HDFux4ldL8uiZLdNrgM= |
| In-reply-to: | <1264864218.32192.1.camel@sakura.staff.proxad.net> |
| Organization: | DSLab, Lanzhou University, China |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20091222014922.GA30164@dvomlehn-lnx2.corp.sa.net> <1264864218.32192.1.camel@sakura.staff.proxad.net> |
| Reply-to: | wuzhangjin@gmail.com |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sat, 2010-01-30 at 16:10 +0100, Maxime Bizon wrote:
> On Mon, 2009-12-21 at 17:49 -0800, David VomLehn wrote:
>
> Hi,
>
> > if (cpu_has_mips_r2) {
> > - cp0_compare_irq = (read_c0_intctl() >> 29) & 7;
> > - cp0_perfcount_irq = (read_c0_intctl() >> 26) & 7;
> > + cp0_compare_irq_shift = CAUSEB_TI - CAUSEB_IP;
> > + cp0_compare_irq = (read_c0_intctl() >> INTCTLB_IPTI) & 7;
> > + cp0_perfcount_irq = (read_c0_intctl() >> INTCTLB_IPPCI) & 7;
>
> This patch breaks at least bcm63xx, because cp0_compare_irq_shift is not
> initialized when cpu_has_mips_r2 is false.
Yes, that patch have broken the CEVT_R4K support in the archs whose
cpu_has_mips_r2 is false.
I will send a piece of patch to fix it.
Thanks & Regards,
Wu Zhangjin
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 0/3] AR7 cleanups and fixes, Florian Fainelli |
|---|---|
| Next by Date: | [PATCH urgent] MIPS: Fixup of the r4k timer, Wu Zhangjin |
| Previous by Thread: | Re: [PATCH 0/3] AR7 cleanups and fixes, Florian Fainelli |
| Next by Thread: | [PATCH urgent] MIPS: Fixup of the r4k timer, Wu Zhangjin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |