| To: | David VomLehn <dvomlehn@cisco.com> |
|---|---|
| Subject: | Re: [PATCH] powertv: Fix support for timer interrupts when using >64 external IRQs |
| From: | Maxime Bizon <mbizon@freebox.fr> |
| Date: | Sat, 30 Jan 2010 16:10:18 +0100 |
| Cc: | linux-mips@linux-mips.org, ralf@linux-mips.org |
| In-reply-to: | <20091222014922.GA30164@dvomlehn-lnx2.corp.sa.net> |
| Organization: | Freebox |
| References: | <20091222014922.GA30164@dvomlehn-lnx2.corp.sa.net> |
| Reply-to: | mbizon@freebox.fr |
| Sender: | linux-mips-bounce@linux-mips.org |
On Mon, 2009-12-21 at 17:49 -0800, David VomLehn wrote:
Hi,
> if (cpu_has_mips_r2) {
> - cp0_compare_irq = (read_c0_intctl() >> 29) & 7;
> - cp0_perfcount_irq = (read_c0_intctl() >> 26) & 7;
> + cp0_compare_irq_shift = CAUSEB_TI - CAUSEB_IP;
> + cp0_compare_irq = (read_c0_intctl() >> INTCTLB_IPTI) & 7;
> + cp0_perfcount_irq = (read_c0_intctl() >> INTCTLB_IPPCI) & 7;
This patch breaks at least bcm63xx, because cp0_compare_irq_shift is not
initialized when cpu_has_mips_r2 is false.
Regards,
--
Maxime
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Kernel crash in 2.6.32.6 / bcm1480 with 16k page size, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH 3/3] MIPS: deal with larger physical offsets, Maxime Bizon |
| Previous by Thread: | Re: [PATCH] powertv: Fix support for timer interrupts when using >64 external IRQs, Ralf Baechle |
| Next by Thread: | [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support, Wu Zhangjin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |