linux-mips
[Top] [All Lists]

Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Wed, 27 Jan 2010 00:01:19 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=7VB56DLezdSktQD/grvI8gg1tFRHtIEnz07mFfCYeDY=; b=dp65Ydem8+i/MgkNFeqhy4InLkAc5SGEvLvyZp8c/ix1wF9sgutHczUkoSFWU68oUN SxmK/Ju47cHNMgrHXpIM+ZxMBXUy+daTInvKbXUFvPWaLlDsQy2obcb2faOo9KanaCv0 JQqgBI1bwCuLwSImI7/0jhYrpiEOf989xPXvA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=M4nXKRmVh2JmGcI5F2C4vigYTEaxhb4vEaW0j3yXD89+IYWRL7MtyT7g4jhxSX1+y4 7PlMrrtXsitCptetbzsPhS6Q23l9i+3cKLfhgkdHawiY/39GwhDZr4xEE/YoB1aC+Xjp bOxjPWi8lAPq438glkJ4Yt/SkEb7sT6qnVKmM=
In-reply-to: <1264521494.24895.28.camel@falcon>
Organization: DSLab, Lanzhou University, China
References: <8c337354c30ac911207df81abd13197c897b2380.1264517495.git.wuzhangjin@gmail.com> <f861ec6f1001260728x64c54ec7m65bc6ebc0ee64a80@mail.gmail.com> <1264521494.24895.28.camel@falcon>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2010-01-26 at 23:58 +0800, Wu Zhangjin wrote:
> On Tue, 2010-01-26 at 16:28 +0100, Manuel Lauss wrote:
> > Hi,
> > 
> > On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > > Changes from v1 (feedbacks from Ralf):
> > >
> > >  o make DEBUG_ZBOOT also depend on DEBUG_KERNEL
> > >
> > >  o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so 
> > > simplify the
> > 
> > Not every chip has a standard 16550, unfortunately.  I liked your
> > first iteration better:
> > DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL)  another
> > (invisible)
> > config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550
> > for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for 
> > unsupported
> > chips).
> > 
> 
> Yes, It will be not convenient for a new serial port debugging support
> with the current modification, for example, if you add UARTXXXX, we need
> to select it for the new board and also add it under the "depends" of
> DEBUG_ZBOOT. how about this?
> 
> diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
> index 5e556f7..6fccbf0 100644
> --- a/arch/mips/Kconfig.debug
> +++ b/arch/mips/Kconfig.debug
> @@ -104,7 +104,7 @@ config RUNTIME_DEBUG
>  
>  config DEBUG_ZBOOT
>         bool "Enable compressed kernel support debugging"
> -       depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT_UART16550
> +       depends on DEBUG_KERNEL
> 

oh, no, this dependency is also needed: SYS_SUPPORTS_ZBOOT, so, it
should be:

depends on DEBUG_KERNEL && SYS_SUPPORTS_ZBOOT

> and we keep the old:
> 
> ifdef CONFIG_DEBUG_ZBOOT
> obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> endif
> 
> If a new serial port is needed, we just need to add the following lines
> to arch/mips/Kconfig
> 
> config SYS_SUPPORTS_ZBOOT_UARTXXX
>       bool
>       select SYS_SUPPORTS_ZBOOT
> 
> config MACH_XXXX
>       [...]
>       select SYS_SUPPORTS_ZBOOT_UARTXXX
>       [...]
> 
> and in arch/mips/boot/compressed/Makfefile
> 
> ifdef CONFIG_DEBUG_ZBOOT
> obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UARTXXX) += $(obj)/uart-xxx.o
> endif
> 
> and also a new arch/mips/boot/compressed/uar-xxx.c is needed.
> 
> If this is okay, I will send a new revision asap.
> 
> Regards,
>       Wu Zhangjin



<Prev in Thread] Current Thread [Next in Thread>