linux-mips
[Top] [All Lists]

Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH -queue v2] MIPS: Cleanup the debugging of compressed kernel support
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Tue, 26 Jan 2010 16:28:59 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=KkSqBPQ0/cI2DoWWOkKbZ3pI7MZDsbNuLJZxypRg3IQ=; b=VEumxtHeJcQe5dBaXB/jmc09LW050iIt3LA/RMxHN75B7U24f5R0METAcgM91rOSYI QelDhpQnDcTYCtj47isqMOFwVzOSgeAj6N7JifW3SyfDK26Sdz9FIAC659G5s9D9UGUq VR9G8dCmn+qhWcdlbTQMrK0uwr2BECfj7vSPQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=uenV2T/OJmxmd1RXW0soXe3SiWFjRjzZW4UmsI+ozpMqRVIK326qYd4H3+9iUJVPwF d6mb6+laoKzw6JyJufqmxUUM0A/xynHpqSo6KWQFlD9Esh5/UGHkNm2TWV4vq3ct2rx9 SHFwJHPrD7VMdAGXOqROxSUb3w6SEbF2SMg1E=
In-reply-to: <8c337354c30ac911207df81abd13197c897b2380.1264517495.git.wuzhangjin@gmail.com>
References: <8c337354c30ac911207df81abd13197c897b2380.1264517495.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Hi,

On Tue, Jan 26, 2010 at 4:02 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> Changes from v1 (feedbacks from Ralf):
>
>  o make DEBUG_ZBOOT also depend on DEBUG_KERNEL
>
>  o DEBUG_ZBOOT already depends on SYS_SUPPORTS_ZBOOT_UART16550 so simplify the

Not every chip has a standard 16550, unfortunately.  I liked your
first iteration better:
DEBUG_ZBOOT visible at all times (or depend on DEBUG_KERNEL)  another
(invisible)
config symbol selecting the code to build (i.e. SYS_SUPPORTS_ZBOOT_UART16550
for your loongson boxes, MACH_ALCHEMY for alchemy, and nothing for unsupported
chips).


>  obj-$(CONFIG_DEBUG_ZBOOT_UART16550) into just obj-$(CONFIG_DEBUG_ZBOOT) and
>  no ifdef.

The last hunk does something else:

> -obj-$(CONFIG_SYS_SUPPORTS_ZBOOT_UART16550) += $(obj)/uart-16550.o
> +obj-$(CONFIG_SYS_SUPPORTS_ZBOOT) += $(obj)/uart-16550.o

Manuel

<Prev in Thread] Current Thread [Next in Thread>