linux-mips
[Top] [All Lists]

Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of

To: wuzhangjin@gmail.com
Subject: Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f
From: David Brownell <david-b@pacbell.net>
Date: Mon, 25 Jan 2010 18:03:09 -0800
Cc: Alessandro Zummo <a.zummo@towertech.it>, rtc-linux@googlegroups.com, Paul Gortmaker <p_gortmaker@yahoo.com>, linux-mips@linux-mips.org
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=LgDzKNDoO+3AS3svad7RIIicYFfEuxJtb6jaW1MFnc4uxhfzW5eUz4SWdqv1lABzHAJlkbIbRK4d8pnSCA2gzbWESuPj5AGj55H6gHl+b7M4EOU/Qt372rZUimD5gLEKXn6faRwYkuNr0DnSPcvKct08qNG4wSMFpCYlVZFs1YI= ;
In-reply-to: <1259858696.7536.28.camel@falcon.domain.org>
References: <cover.1257383766.git.wuzhangjin@gmail.com> <20091203172735.7c934f61@linux.lan.towertech.it> <1259858696.7536.28.camel@falcon.domain.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.10
On Thursday 03 December 2009, Wu Zhangjin wrote:
> On Thu, 2009-12-03 at 17:27 +0100, Alessandro Zummo wrote:
> > On Thu,  5 Nov 2009 09:22:09 +0800
> > Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > 
> > >    */
> > > - if (is_valid_irq(rtc_irq) &&
> > > -     (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> > > -         dev_dbg(dev, "only 24-hr BCD mode supported\n");
> > > + if (is_valid_irq(rtc_irq) && !(rtc_control & RTC_24H)) {
> > > +         dev_dbg(dev, "only 24-hr supported\n");
> > 
> >  If this check was there it's probably because there are problems
> >  in some other parts of the driver. I'm not keen to add this without
> >  some feedback by the original author or porter.

As *already* noted in the code:  <asm-generic/rtc.h> only handles BCD.
And that's what's used to access most of those registers.



<Prev in Thread] Current Thread [Next in Thread>
  • Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f, David Brownell <=