linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports.

To: Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports.
From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 25 Jan 2010 10:19:14 -0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-i2c@vger.kernel.org, khali@linux-fr.org, rade.bozic.ext@nsn.com, ml.lawnick@gmx.de
In-reply-to: <20100124160017.GF28675@fluff.org.uk>
References: <4B463B1F.6000404@caviumnetworks.com> <1262894061-32613-2-git-send-email-ddaney@caviumnetworks.com> <20100124160017.GF28675@fluff.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Ben Dooks wrote:
On Thu, Jan 07, 2010 at 11:54:20AM -0800, David Daney wrote:
From: Rade Bozic <rade.bozic.ext@nsn.com>

Signed-off-by: Rade Bozic <rade.bozic.ext@nsn.com>
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
 drivers/i2c/busses/Kconfig      |   10 +
 drivers/i2c/busses/Makefile     |    1 +
 drivers/i2c/busses/i2c-octeon.c |  579 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 590 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-octeon.c
[...]
+
+#ifndef NO_IRQ
+#define NO_IRQ (-1)
+#endif

this does not fill me with a warm joyous feeling...

Indeed.

[ many other helpful comments deleted for brevity.]

We will improve the driver and resubmit.

Thanks for looking at it.

David Daney

<Prev in Thread] Current Thread [Next in Thread>