Re: [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports.

[David Daney <ddaney@caviumnetworks.com>]

Ben Dooks wrote:
> On Thu, Jan 07, 2010 at 11:54:20AM -0800, David Daney wrote:
> > From: Rade Bozic <rade.bozic.ext@nsn.com>
> >
> > Signed-off-by: Rade Bozic <rade.bozic.ext@nsn.com>
> > Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> > ---
> >  drivers/i2c/busses/Kconfig      |   10 +
> >  drivers/i2c/busses/Makefile     |    1 +
> >  drivers/i2c/busses/i2c-octeon.c |  579 +++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 590 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/i2c/busses/i2c-octeon.c
[...]
> > +
> > +#ifndef NO_IRQ
> > +#define NO_IRQ (-1)
> > +#endif
> this does not fill me with a warm joyous feeling... 
Indeed.

[ many other helpful comments deleted for brevity.]

We will improve the driver and resubmit.

Thanks for looking at it.

David Daney