linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: cleanup switches with cases that can be merged

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: cleanup switches with cases that can be merged
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 23 Jan 2010 17:31:58 +0100
Cc: Roel Kluin <roel.kluin@gmail.com>, linux-mips@linux-mips.org, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>
In-reply-to: <4B56641E.1030803@caviumnetworks.com>
References: <4B56475F.8070608@gmail.com> <4B56641E.1030803@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Tue, Jan 19, 2010 at 06:02:06PM -0800, David Daney wrote:

> This patch should be split up.
> 
> Octeon, PowerTV, and IP32 are all different architectures.  They
> should be in their own patches.
> 
> The two math-emu parts could probably go together.
> 
> cpu-probe seems like its own thing.

It's conceptually the same change that's being applied everywhere and the
total size is modest so I'm happy to apply it as just a single patch as is.

> This brings us to the larger question:  This is just code churn.  Is
> it even worthwhile?

This has been discussed many times over and we maintainers have not come to
a final conclusion on this type of patches.  I tend to apply this sort of
patches anyway but treat them as low priority.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>