linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: cleanup switches with cases that can be merged

To: Roel Kluin <roel.kluin@gmail.com>
Subject: Re: [PATCH] MIPS: cleanup switches with cases that can be merged
From: David Daney <ddaney@caviumnetworks.com>
Date: Tue, 19 Jan 2010 18:02:06 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>
In-reply-to: <4B56475F.8070608@gmail.com>
References: <4B56475F.8070608@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Roel Kluin wrote:
I did a search for switch statements with cases that can be merged, but maybe
some were not intended?
---------------->8------------------------------------------8<-----------------
In these cases the same code was executed.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 arch/mips/include/asm/octeon/octeon-feature.h |    8 ++------
 arch/mips/kernel/cpu-probe.c                  |    3 ---
 arch/mips/math-emu/ieee754dp.c                |    1 -
 arch/mips/math-emu/ieee754sp.c                |    1 -
 arch/mips/pci/pci-octeon.c                    |    6 ++----
 arch/mips/powertv/asic/asic_devices.c         |    4 ----
 arch/mips/sgi-ip32/ip32-irq.c                 |    9 +--------
 7 files changed, 5 insertions(+), 27 deletions(-)

This patch should be split up.

Octeon, PowerTV, and IP32 are all different architectures. They should be in their own patches.

The two math-emu parts could probably go together.

cpu-probe seems like its own thing.

This brings us to the larger question: This is just code churn. Is it even worthwhile?


David Daney




<Prev in Thread] Current Thread [Next in Thread>