| To: | Andreas Mohr <andi@lisas.de> |
|---|---|
| Subject: | Re: [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures |
| From: | Takashi Iwai <tiwai@suse.de> |
| Date: | Thu, 14 Jan 2010 08:54:08 +0100 |
| Cc: | alsa-devel@alsa-project.org, Ralf Baechle <ralf@linux-mips.org>, Wu Zhangjin <wuzhangjin@gmail.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, linux-mips@linux-mips.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Kumar Gala <galak@gate.crashing.org>, Becky Bruce <beckyb@kernel.crashing.org> |
| In-reply-to: | <20100114074638.GA12266@rhlx01.hs-esslingen.de> |
| References: | <1259248388-20095-1-git-send-email-tiwai@suse.de> <20100101193130.GA21510@rhlx01.hs-esslingen.de> <s5haawj7qlv.wl%tiwai@suse.de> <s5hljg24bl7.wl%tiwai@suse.de> <20100114074638.GA12266@rhlx01.hs-esslingen.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
At Thu, 14 Jan 2010 08:46:38 +0100, Andreas Mohr wrote: > > On Wed, Jan 13, 2010 at 10:07:32AM +0100, Takashi Iwai wrote: > > > As I mentioned in the previous followup, if your device is a > > > USB-audio, the patch doesn't help because it's for devices with > > > buffers using dma_alloc_coherent(). For USB-audio, it uses vmalloc > > > for an intermediate buffer. Maybe this should be changed to dma_*() > > > stuff for such architectures. > > > > A quick patch below (totally untested!) might do that. > > It's passing the device struct blindly, so not sure whether this would > > actually work for all dma_alloc_coherent(). > > Thanks a lot, tested, but AFAICS there isn't much of a change unfortunately > (log below). Of course, not for the crash. The patch was for improving the sound quality (if any). Takashi |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures, Andreas Mohr |
|---|---|
| Next by Date: | Re: [PATCH 00/24] MAINTAINERS: Add "Q" patchwork entries, David Daney |
| Previous by Thread: | Re: [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures, Andreas Mohr |
| Next by Thread: | Re: [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures, Benjamin Herrenschmidt |
| Indexes: | [Date] [Thread] [Top] [All Lists] |