linux-mips
[Top] [All Lists]

Re: [PATCH 4/8] resources: introduce generic page_is_ram()

To: Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH 4/8] resources: introduce generic page_is_ram()
From: Américo Wang <xiyou.wangcong@gmail.com>
Date: Wed, 13 Jan 2010 22:29:23 +0800
Cc: Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Chen Liqin <liqin.chen@sunplusct.com>, Lennox Wu <lennox.wu@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Andi Kleen <andi@firstfloor.org>, Nick Piggin <npiggin@suse.de>, Hugh Dickins <hugh.dickins@tiscali.co.uk>, Linux Memory Management List <linux-mm@kvack.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=JajmBVxDNaLfwJXYXb2NNIA+1FWIqwXCEAMNkGFKQY4=; b=k1hMyMbf7V74PSp5W34IV+d3IlBr2QLbmzNX6/Thzh+J/f8Je0rHfMoFsX7sRAfQJz 6yAE/ICtScbQivMQVXi0kG/JtS5xyRQ++80VdjSz6Lp7VV1naGZcgwVQJdzFmiDBP7Yr ySUVG4Y5fYAHQmiKma38YpKtRxauPpicM2v4g=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=kkAWeNzKNYBBRgeJPsre4evAI4Abfx1fwllf5Ivz/0kIm4dcgWGDTJr2H1vTYK+KLD NPssrTi1aQAuoKmzygTRn7dgi589JA6wQqg2/GwW5k29WpHs0QoZ6RmmFLsDYFDX+RIZ spjvJ+jf8G1J0O9CJssWX4S/+Jtk+noAwl09Y=
In-reply-to: <20100113135957.680223335@intel.com>
References: <20100113135305.013124116@intel.com> <20100113135957.680223335@intel.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Jan 13, 2010 at 09:53:09PM +0800, Wu Fengguang wrote:
>It's based on walk_system_ram_range(), for archs that don't have
>their own page_is_ram().
>
>The static verions in MIPS and SCORE are also made global.
>
>CC: Chen Liqin <liqin.chen@sunplusct.com>
>CC: Lennox Wu <lennox.wu@gmail.com>
>CC: Ralf Baechle <ralf@linux-mips.org>
>CC: linux-mips@linux-mips.org
>CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> 
>Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
>---
> arch/mips/mm/init.c    |    2 +-
> arch/score/mm/init.c   |    2 +-
> include/linux/ioport.h |    2 ++
> kernel/resource.c      |   10 ++++++++++
> 4 files changed, 14 insertions(+), 2 deletions(-)
>
>--- linux-mm.orig/kernel/resource.c    2010-01-10 10:11:53.000000000 +0800
>+++ linux-mm/kernel/resource.c 2010-01-10 10:15:33.000000000 +0800
>@@ -297,6 +297,16 @@ int walk_system_ram_range(unsigned long 
> 
> #endif
> 
>+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
>+{
>+      return 24;
>+}
>+
>+int __attribute__((weak)) page_is_ram(unsigned long pfn)
>+{
>+      return 24 == walk_system_ram_range(pfn, 1, NULL, __is_ram);
>+}


Why do you choose 24 instead of using a macro expressing its meaning?


>+
> /*
>  * Find empty slot in the resource tree given range and alignment.
>  */
>--- linux-mm.orig/include/linux/ioport.h       2010-01-10 10:11:53.000000000 
>+0800
>+++ linux-mm/include/linux/ioport.h    2010-01-10 10:11:54.000000000 +0800
>@@ -188,5 +188,7 @@ extern int
> walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
>               void *arg, int (*func)(unsigned long, unsigned long, void *));
> 
>+extern int page_is_ram(unsigned long pfn);
>+
> #endif /* __ASSEMBLY__ */
> #endif        /* _LINUX_IOPORT_H */
>--- linux-mm.orig/arch/score/mm/init.c 2010-01-10 10:35:38.000000000 +0800
>+++ linux-mm/arch/score/mm/init.c      2010-01-10 10:38:04.000000000 +0800
>@@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi
> }
> 
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>-static int __init page_is_ram(unsigned long pagenr)
>+int page_is_ram(unsigned long pagenr)
> {
>       if (pagenr >= min_low_pfn && pagenr < max_low_pfn)
>               return 1;
>--- linux-mm.orig/arch/mips/mm/init.c  2010-01-10 10:37:22.000000000 +0800
>+++ linux-mm/arch/mips/mm/init.c       2010-01-10 10:37:26.000000000 +0800
>@@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long 
> }
> 
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>-static int __init page_is_ram(unsigned long pagenr)
>+int page_is_ram(unsigned long pagenr)
> {
>       int i;
> 
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 

<Prev in Thread] Current Thread [Next in Thread>