| To: | Greg KH <gregkh@suse.de> |
|---|---|
| Subject: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling. |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 12 Jan 2010 12:36:19 +0100 |
| Cc: | David Daney <ddaney@caviumnetworks.com>, Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-mips@linux-mips.org, netdev@vger.kernel.org |
| In-reply-to: | <20100107215950.GA24672@suse.de> |
| References: | <4B463005.8060505@caviumnetworks.com> <1262891106-32146-1-git-send-email-ddaney@caviumnetworks.com> <4B4645EE.5050302@ru.mvista.com> <4B464977.2090801@caviumnetworks.com> <20100107215950.GA24672@suse.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.20 (2009-08-17) |
On Thu, Jan 07, 2010 at 01:59:50PM -0800, Greg KH wrote: > >>> If an interrupt handler disables interrupts, the EOI function will > >>> just reenable them. This will put us in an endless loop when the > >>> upcoming Ethernet driver patches are applied. > >>> > >>> Only reenable the interrupt on EOI if it is not IRQ_DISABLED. This > >>> requires that the EIO function be separate from the ENABLE function. > >>> We also rename the ACK functions to correspond with their function. > >>> > >>> Signed-off-by: David Daney <ddaney@caviumnetworks.com> > >>> > >> > >> I guess the subject should read "EIO", not "EIO"... > >> > > > > Indeed. The compiler didn't catch that one. > > > > Perhaps Ralf can fix it if he merges it, otherwise I can resubmit with > > corrected spelling. > > I can change it when merging, don't worry about it. This is a driver specific to a specific MIPS platform so I think this series should be merged via the MIPS tree and assuming Greg is ok with that I have merged this into my tree. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: Remove unused macros from barrier.h, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling., Greg KH |
| Previous by Thread: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling., Greg KH |
| Next by Thread: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling., Greg KH |
| Indexes: | [Date] [Thread] [Top] [All Lists] |