| To: | Sergei Shtylyov <sshtylyov@ru.mvista.com> |
|---|---|
| Subject: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling. |
| From: | David Daney <ddaney@caviumnetworks.com> |
| Date: | Thu, 07 Jan 2010 12:52:07 -0800 |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org, netdev@vger.kernel.org, gregkh@suse.de |
| In-reply-to: | <4B4645EE.5050302@ru.mvista.com> |
| References: | <4B463005.8060505@caviumnetworks.com> <1262891106-32146-1-git-send-email-ddaney@caviumnetworks.com> <4B4645EE.5050302@ru.mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Sergei Shtylyov wrote: Hello. David Daney wrote:If an interrupt handler disables interrupts, the EOI function will just reenable them. This will put us in an endless loop when the upcoming Ethernet driver patches are applied. Only reenable the interrupt on EOI if it is not IRQ_DISABLED. This requires that the EIO function be separate from the ENABLE function. We also rename the ACK functions to correspond with their function. Signed-off-by: David Daney <ddaney@caviumnetworks.com>I guess the subject should read "EIO", not "EIO"... Indeed. The compiler didn't catch that one.Perhaps Ralf can fix it if he merges it, otherwise I can resubmit with corrected spelling. David Daney |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] MIPS: Octeon: Add I2C platform driver., David Daney |
|---|---|
| Next by Date: | [PATCH 1/3] MIPS: Octeon: Add I2C platform device., David Daney |
| Previous by Thread: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling., Sergei Shtylyov |
| Next by Thread: | Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling., Greg KH |
| Indexes: | [Date] [Thread] [Top] [All Lists] |