linux-mips
[Top] [All Lists]

Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 1/7] MIPS: Octeon: Fix EIO handling.
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 07 Jan 2010 23:37:02 +0300
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, netdev@vger.kernel.org, gregkh@suse.de
In-reply-to: <1262891106-32146-1-git-send-email-ddaney@caviumnetworks.com>
References: <4B463005.8060505@caviumnetworks.com> <1262891106-32146-1-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)
Hello.

David Daney wrote:

If an interrupt handler disables interrupts, the EOI function will
just reenable them.  This will put us in an endless loop when the
upcoming Ethernet driver patches are applied.

Only reenable the interrupt on EOI if it is not IRQ_DISABLED.  This
requires that the EIO function be separate from the ENABLE function.
We also rename the ACK functions to correspond with their function.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>

  I guess the subject should read "EIO", not "EIO"...

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>