linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] Staging: Octeon Ethernet: Clean up and convert to NAPI.

To: ddaney@caviumnetworks.com
Subject: Re: [PATCH 2/3] Staging: Octeon Ethernet: Clean up and convert to NAPI.
From: David Miller <davem@davemloft.net>
Date: Wed, 06 Jan 2010 17:01:38 -0800 (PST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, netdev@vger.kernel.org, gregkh@suse.de
In-reply-to: <1262825836-9457-2-git-send-email-ddaney@caviumnetworks.com>
References: <4B4530F3.1070701@caviumnetworks.com> <1262825836-9457-2-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed,  6 Jan 2010 16:57:15 -0800

> Convert the driver to be a reasonably well behaved NAPI citizen.  Also
> clean up memory allocation and tx buffer accounding code.  Remove some
> configuration #defines and other unused code that are not applicable
> to the in-tree driver.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>

Please seperate the cleanups and conversion to NAPI into seperate
patches.

Doing both at the same time makes your patch impossible to review.

<Prev in Thread] Current Thread [Next in Thread>