linux-mips
[Top] [All Lists]

Re: [PATCH 4/5] MIPS: remove unused powertv platform_die()

To: Yoichi Yuasa <yuasa@linux-mips.org>
Subject: Re: [PATCH 4/5] MIPS: remove unused powertv platform_die()
From: David VomLehn <dvomlehn@cisco.com>
Date: Mon, 21 Dec 2009 17:36:13 -0800
Authentication-results: sj-iport-5.cisco.com; dkim=neutral (message not signed) header.i=none
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <20091218213632.7d5b0037.yuasa@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20091218212917.f42e8180.yuasa@linux-mips.org> <20091218213018.79a9fc11.yuasa@linux-mips.org> <20091218213346.01f63eac.yuasa@linux-mips.org> <20091218213632.7d5b0037.yuasa@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Dec 18, 2009 at 09:36:32PM +0900, Yoichi Yuasa wrote:
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
> ---
>  arch/mips/powertv/powertv_setup.c |   21 ---------------------
>  1 files changed, 0 insertions(+), 21 deletions(-)
> 
> diff --git a/arch/mips/powertv/powertv_setup.c 
> b/arch/mips/powertv/powertv_setup.c
> index bd8ebf1..698b1ea 100644
> --- a/arch/mips/powertv/powertv_setup.c
> +++ b/arch/mips/powertv/powertv_setup.c
> @@ -64,9 +64,6 @@
>  #define REG_SIZE     "4"             /* In bytes */
>  #endif
>  
> -static struct pt_regs die_regs;
> -static bool have_die_regs;
> -
>  static void register_panic_notifier(void);
>  static int panic_handler(struct notifier_block *notifier_block,
>       unsigned long event, void *cause_string);
> @@ -218,24 +215,6 @@ static int panic_handler(struct notifier_block 
> *notifier_block,
>       return NOTIFY_DONE;
>  }
>  
> -/**
> - * Platform-specific handling of oops
> - * @str:     Pointer to the oops string
> - * @regs:    Pointer to the oops registers
> - * All we do here is to save the registers for subsequent printing through
> - * the panic notifier.
> - */
> -void platform_die(const char *str, const struct pt_regs *regs)
> -{
> -     /* If we already have saved registers, don't overwrite them as they
> -      * they apply to the initial fault */
> -
> -     if (!have_die_regs) {
> -             have_die_regs = true;
> -             die_regs = *regs;
> -     }
> -}
> -
>  /* Information about the RF MAC address, if one was supplied on the
>   * command line. */
>  static bool have_rfmac;
> -- 
> 1.6.5.7
> 
> 
Looks good, thanks!
Reviewed-by: David VomLehn (dvomlehn@cisco.com)


<Prev in Thread] Current Thread [Next in Thread>