linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: add readl/write_be

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 2/2] MIPS: add readl/write_be
From: Florian Fainelli <ffainelli@freebox.fr>
Date: Mon, 14 Dec 2009 18:02:13 +0100
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>, ralf@linux-mips.org
In-reply-to: <20091212193114.GA11103@alpha.franken.de>
Organization: Freebox
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200912121757.56365.ffainelli@freebox.fr> <20091212193114.GA11103@alpha.franken.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.12.2 (Linux/2.6.31-16-server; KDE/4.3.2; x86_64; ; )
Hello Thomas,

On Saturday 12 December 2009 20:31:14 Thomas Bogendoerfer wrote:
> On Sat, Dec 12, 2009 at 05:57:56PM +0100, Florian Fainelli wrote:
> > +#define readl_be(addr)                     __raw_readl((__force unsigned 
> > *)addr)
> > +#define writel_be(val, addr)               __raw_writel(val, (__force 
> > unsigned
> > *)addr)
> 
> looks broken for little endian machines. __raw_XXX doesn't do any swapping,
> so IMHO the correct thing would be to use be32_to_cpu/cpu_to_be32.

Yeah, I missed that point. Please find below version 2 of the patch which also 
addresses David's comment.
--
From: Florian Fainelli <ffainelli@freebox.fr>
Subject: [PATCH v2] MIPS: add readl_be/writel_be

MIPS currently lacks the readl_be and writel_be accessors
which are required by BCM63xx for OHCI and EHCI support.
Let's define them globally for MIPS. This also fixes the
compilation of the bcm63xx defconfig against USB.

Changes from v1:
- make it work on little-endian machines
- protect macros arguments with parenthesis

Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
---
diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index 436878e..4a76d39 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -447,6 +447,9 @@ __BUILDIO(q, u64)
 #define readl_relaxed                  readl
 #define readq_relaxed                  readq
 
+#define readl_be(addr)                 cpu_to_be32(__raw_readl((__force 
unsigned *)(addr)))
+#define writel_be(val, addr)           __raw_writel(be32_to_cpu((val)), 
(__force unsigned *)(addr))
+
 /*
  * Some code tests for these symbols
  */
-- 

<Prev in Thread] Current Thread [Next in Thread>