linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: add readl/write_be

To: Florian Fainelli <ffainelli@freebox.fr>
Subject: Re: [PATCH 2/2] MIPS: add readl/write_be
From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 14 Dec 2009 08:40:21 -0800
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>, ralf@linux-mips.org
In-reply-to: <200912121757.56365.ffainelli@freebox.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200912121757.56365.ffainelli@freebox.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Florian Fainelli wrote:
MIPS currently lacks the readl_be and writel_be accessors
which are required by BCM63xx for OHCI and EHCI support.
Let's define them globally for MIPS. This also fixes the
compilation of the bcm63xx defconfig against USB.

Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
---
diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index 436878e..65cb4e4 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -447,6 +447,9 @@ __BUILDIO(q, u64)
 #define readl_relaxed                  readl
 #define readq_relaxed                  readq
+#define readl_be(addr) __raw_readl((__force unsigned *)addr)
+#define writel_be(val, addr)           __raw_writel(val, (__force unsigned 
*)addr)
+


Without addressing the need for the patch, as a technical matter, the macro parameters should probably be protected by parenthesis. I.E.:

#define readl_be(addr)                  __raw_readl((__force unsigned *)(addr))
#define writel_be(val, addr) __raw_writel((val), (__force unsigned *)(addr))

<Prev in Thread] Current Thread [Next in Thread>