linux-mips
[Top] [All Lists]

Re: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver
From: Pavel Machek <pavel@ucw.cz>
Date: Tue, 8 Dec 2009 08:09:15 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, akpm@linux-foundation.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, "Rafael J . Wysocki" <rjw@sisk.pl>, zhangfx@lemote.com, linux-laptop@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>
In-reply-to: <1260183663.9092.51.camel@falcon.domain.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1260082252.git.wuzhangjin@gmail.com> <d8789fa7e97d8a170c4e2516d7ef2d2fbbe42cc6.1260082252.git.wuzhangjin@gmail.com> <20091206084717.GD2766@ucw.cz> <1260147298.3126.2.camel@falcon.domain.org> <20091207080446.GB23088@elf.ucw.cz> <1260178870.9092.34.camel@falcon.domain.org> <20091207094909.GD23088@elf.ucw.cz> <1260183663.9092.51.camel@falcon.domain.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
> > > > That's certainly better. But... why not return signed value? Current
> > > > flowing from the battery is certainly very different from current
> > > > flowing into it...
> > > 
> > > You are totally right ;)
> > > 
> > > Just test it, when flowing from the battery, the value is negative, and
> > > when flowing into the battery, the value is positive, so, no abs()
> > > needed. thanks!
> > 
> > Make it return -value, then. I believe other code uses >0 values for
> > discharge.
> 
> Done, but any document/standard about it?

Not sure, feel free to patch the documentation, too :-).
                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

<Prev in Thread] Current Thread [Next in Thread>