linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] [MIPS] mipssim: remove unused code

To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Subject: Re: [PATCH 1/3] [MIPS] mipssim: remove unused code
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 5 Dec 2009 10:41:58 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <1255546939-3302-2-git-send-email-dmitri.vorobiev@movial.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1255546939-3302-1-git-send-email-dmitri.vorobiev@movial.com> <1255546939-3302-2-git-send-email-dmitri.vorobiev@movial.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Wed, Oct 14, 2009 at 10:02:17PM +0300, Dmitri Vorobiev wrote:

> The function prom_init_cmdline() doesn't do anything, and nobody calls
> the prom_getcmdline() function. Since these two are the only functions
> in the file arch/mips/mipssim/sim_cmdline.c, the whole file can be
> removed now along with the call to the no-op prom_init_cmdline()
> routine.
> 
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>

And obviously not compile tested:

  CC      arch/mips/mipssim/sim_int.o
make[3]: *** No rule to make target `arch/mips/mipssim/sim_cmdline.o', needed 
by `arch/mips/mipssim/built-in.o'.  Stop.
make[2]: *** [arch/mips/mipssim] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2

  Ralf

<Prev in Thread] Current Thread [Next in Thread>