linux-mips
[Top] [All Lists]

Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of

To: Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Fri, 04 Dec 2009 00:44:56 +0800
Cc: rtc-linux@googlegroups.com, Paul Gortmaker <p_gortmaker@yahoo.com>, linux-mips@linux-mips.org, David Brownell <dbrownell@users.sourceforge.net>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=VDq6w8GMKaQTSKuRgUgOMOd+wgaI9kvlq27e7EhUChM=; b=mOjaOmmT9+2SYpu72dB/WX9yXXQqDsMBowMP98LcKJj46w+Lx0dQoPqPYFt4uwHNA5 y9V4jryNvPvJk0wdsPx6Z6kGchZCXUSCzMD5gFrTrDPbgWxDDs0H+MtQzHQfjeCk6tZy hFIXLQarYhN/MIFyjI0oSZ9gnXDVFM5/MEt0s=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=HK60iBTNHjBBtZrKvtkQImpnhFNTV/v60Q3cPUu3e5EZXsa+r/X1uZdMVUa8f8d/22 7d3jbHb6XJQUtZkR6lyKoLs+PCUFvL6PPwlnE/tB05XIj7GgeVofqOo9R91S0zCUa9Jl KDSIHBq24vjIDZGwUqHF595a5rbrigADVYKsw=
In-reply-to: <20091203172735.7c934f61@linux.lan.towertech.it>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1257383766.git.wuzhangjin@gmail.com> <f05318584db5160d73af2cfb36b4e3e481a7e7a4.1257383766.git.wuzhangjin@gmail.com> <20091203172735.7c934f61@linux.lan.towertech.it>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2009-12-03 at 17:27 +0100, Alessandro Zummo wrote:
> On Thu,  5 Nov 2009 09:22:09 +0800
> Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> 
> >      */
> > -   if (is_valid_irq(rtc_irq) &&
> > -       (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> > -           dev_dbg(dev, "only 24-hr BCD mode supported\n");
> > +   if (is_valid_irq(rtc_irq) && !(rtc_control & RTC_24H)) {
> > +           dev_dbg(dev, "only 24-hr supported\n");
> 
>  If this check was there it's probably because there are problems
>  in some other parts of the driver. I'm not keen to add this without
>  some feedback by the original author or porter.
> 

Just found two authors or porters from the file: drivers/rtc/rtc-cmos.c

/*
 * RTC class driver for "CMOS RTC":  PCs, ACPI, etc
 *
 * Copyright (C) 1996 Paul Gortmaker (drivers/char/rtc.c)
 * Copyright (C) 2006 David Brownell (convert to new framework)
[...]

and found out their names in MAINTAINERS and put them in the CC list ;)

Regards,
        Wu Zhangjin



<Prev in Thread] Current Thread [Next in Thread>