Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f

[Wu Zhangjin <wuzhangjin@gmail.com>]

On Thu, 2009-12-03 at 17:27 +0100, Alessandro Zummo wrote:
> On Thu,  5 Nov 2009 09:22:09 +0800
> Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> 
> >      */
> > -   if (is_valid_irq(rtc_irq) &&
> > -       (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> > -           dev_dbg(dev, "only 24-hr BCD mode supported\n");
> > +   if (is_valid_irq(rtc_irq) && !(rtc_control & RTC_24H)) {
> > +           dev_dbg(dev, "only 24-hr supported\n");
> 
>  If this check was there it's probably because there are problems
>  in some other parts of the driver. I'm not keen to add this without
>  some feedback by the original author or porter.
> 

Just found two authors or porters from the file: drivers/rtc/rtc-cmos.c

/*
 * RTC class driver for "CMOS RTC":  PCs, ACPI, etc
 *
 * Copyright (C) 1996 Paul Gortmaker (drivers/char/rtc.c)
 * Copyright (C) 2006 David Brownell (convert to new framework)
[...]

and found out their names in MAINTAINERS and put them in the CC list ;)

Regards,
        Wu Zhangjin