linux-mips
[Top] [All Lists]

Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of

To: rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f
From: Alessandro Zummo <a.zummo@towertech.it>
Date: Thu, 3 Dec 2009 17:27:35 +0100
Cc: wuzhangjin@gmail.com, Paul Gortmaker <p_gortmaker@yahoo.com>, linux-mips@linux-mips.org
In-reply-to: <f05318584db5160d73af2cfb36b4e3e481a7e7a4.1257383766.git.wuzhangjin@gmail.com>
Organization: Tower Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1257383766.git.wuzhangjin@gmail.com> <f05318584db5160d73af2cfb36b4e3e481a7e7a4.1257383766.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu,  5 Nov 2009 09:22:09 +0800
Wu Zhangjin <wuzhangjin@gmail.com> wrote:

>        */
> -     if (is_valid_irq(rtc_irq) &&
> -         (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> -             dev_dbg(dev, "only 24-hr BCD mode supported\n");
> +     if (is_valid_irq(rtc_irq) && !(rtc_control & RTC_24H)) {
> +             dev_dbg(dev, "only 24-hr supported\n");

 If this check was there it's probably because there are problems
 in some other parts of the driver. I'm not keen to add this without
 some feedback by the original author or porter.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


<Prev in Thread] Current Thread [Next in Thread>