linux-mips
[Top] [All Lists]

Re: [PATCH v1 1/3] RTC: rtc-cmos.c: fix warning for MIPS

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH v1 1/3] RTC: rtc-cmos.c: fix warning for MIPS
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 3 Dec 2009 15:56:04 +0000
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>, Alessandro Zummo <a.zummo@towertech.it>, linux-mips@linux-mips.org, rtc-linux@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>
In-reply-to: <a91e34bf2595157830d599cb66becd52247b1819.1257383766.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1257383766.git.wuzhangjin@gmail.com> <a91e34bf2595157830d599cb66becd52247b1819.1257383766.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
On Thu, Nov 05, 2009 at 09:21:54AM +0800, Wu Zhangjin wrote:

> This patch fixes the following warning with RTC_LIB on MIPS:
> 
> drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of
> RTC+NVRAM address space, not 64 bytes.
> 
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
>  drivers/rtc/rtc-cmos.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index f7a4701..21e48f7 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -691,7 +691,8 @@ cmos_do_probe(struct device *dev, struct resource *ports, 
> int rtc_irq)
>        */
>  #if  defined(CONFIG_ATARI)
>       address_space = 64;
> -#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) || 
> defined(__sparc__)
> +#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) \
> +                     || defined(__sparc__) || defined(__mips__)
>       address_space = 128;
>  #else
>  #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes.

Ping.

This patch is now nearly a month old and I haven't yet heared anything.
This was actually meant to be 2.6.32 material.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>