linux-mips
[Top] [All Lists]

Re: [PATCH v5 5/8] Loongson: YeeLoong: add hwmon driver

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v5 5/8] Loongson: YeeLoong: add hwmon driver
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Tue, 01 Dec 2009 10:06:03 +0800
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-mips@linux-mips.org, zhangfx@lemote.com, yanh@lemote.com, huhb@lemote.com, lm-sensors@lm-sensors.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=AB5R2EqdxWRT+32k17d2yUY/SQZUz2J+snYCirYyft8=; b=KKWPlMRTWlQU7iBajoOr/kKaWr+/1SL08XFskPpbxaD2AOsChphkX9G3Mnt4+KJjsg eBWFi/Q96V3GhUAAiqVEF9NWWcFQLT5ttK+JyWgMiPMaK7+WFwnFEXkZ3Vohu62dq616 N+R1EzIm7V8KcRkNTNIoa/3vuklOIwrNzklbE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=BzKToS5xjM35u5LZ8bswmbxC49mgCpA8Dy5YGCzadBDYML8xs37RoFko5/mub/dpRw Ii6DO/uOTGEy12WrzU+/lIPLP5eVptdqk+/U0fXPoMuNLxc4vfE1lXrixbax6G2I6vcO 3kiz0jv+5HKiFul/Xh5b7HXGIuvj9zSpKuLe4=
In-reply-to: <20091201014819.GA29728@linux-mips.org>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1259414649.git.wuzhangjin@gmail.com> <ed9926f7d6acbf2abd2eb172ec5147e578dc8fb7.1259414649.git.wuzhangjin@gmail.com> <1259558432.5516.8.camel@falcon.domain.org> <1259562294.5516.16.camel@falcon.domain.org> <20091201014819.GA29728@linux-mips.org>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2009-12-01 at 01:48 +0000, Ralf Baechle wrote:
> On Mon, Nov 30, 2009 at 02:24:54PM +0800, Wu Zhangjin wrote:
> 
> > > > +config YEELOONG_HWMON
> > > > +       tristate "Hardware Monitor Driver"
> > > > +       select HWMON
> > > 
> > > Will use depend in the next version.
> > > 
> > 
> > Sorry, This must be select, there is no other way to select this stuff.
> 
> Why that?

Hmm, sorry, my old explanation is totally Wrong, it's better to select
it for us, just as the x86 platform drivers did:

$ cat drivers/platform/x86/Kconfig | grep " HWMON"
        select HWMON
        select HWMON

Because the HWMON stuff is put in the device drivers as a menuconfig,
but our platform driver is put in its own directory. it will not be
convenient for the users to select it themselves, and also, this select
have no side effect.

Best Regards,
        Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>