linux-mips
[Top] [All Lists]

Re: [PATCH v5 7/8] Loongson: YeeLoong: add suspend driver

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH v5 7/8] Loongson: YeeLoong: add suspend driver
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Sun, 29 Nov 2009 23:35:39 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-mips@linux-mips.org, zhangfx@lemote.com, yanh@lemote.com, huhb@lemote.com, Pavel Machek <pavel@ucw.cz>, linux-pm@lists.linux-foundation.org
In-reply-to: <f758058af5e45ec98bdc849e7762f32d795177e1.1259414649.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1259414649.git.wuzhangjin@gmail.com> <f758058af5e45ec98bdc849e7762f32d795177e1.1259414649.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.12.3 (Linux/2.6.32-rc8-rjw; KDE/4.3.3; x86_64; ; )
On Saturday 28 November 2009, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> This patch adds Suspend Driver, which will suspend the YeeLoong Platform
> specific devices.
> 
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
>  .../loongson/lemote-2f/yeeloong_laptop/Kconfig     |    9 ++
>  .../loongson/lemote-2f/yeeloong_laptop/Makefile    |    1 +
>  .../loongson/lemote-2f/yeeloong_laptop/suspend.c   |  141 
> ++++++++++++++++++++
>  3 files changed, 151 insertions(+), 0 deletions(-)
>  create mode 100644 arch/mips/loongson/lemote-2f/yeeloong_laptop/suspend.c
> 
> diff --git a/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig 
> b/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig
> index c4398ff..49d63c5 100644
> --- a/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig
> +++ b/arch/mips/loongson/lemote-2f/yeeloong_laptop/Kconfig
> @@ -45,4 +45,13 @@ config YEELOONG_VO
>         This option adds Video Output Driver, which provides standard
>         interface to turn on/off the video output of LCD, CRT.
>  
> +config YEELOONG_SUSPEND
> +     tristate "Suspend Driver"

Why tristate?

> +     depends on YEELOONG_HWMON && YEELOONG_VO
> +     select SUSPEND

I'm not sure if that's going to work.  Please make it depend on SUSPEND rather
than select it.

> +     default y
> +     help
> +       This option adds Suspend Driver, which will suspend the YeeLoong
> +       Platform specific devices.
> +
>  endif

Thanks,
Rafael

<Prev in Thread] Current Thread [Next in Thread>