linux-mips
[Top] [All Lists]

Re: [PATCH v5 8/8] Loongson: YeeLoong: add hotkey driver

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH v5 8/8] Loongson: YeeLoong: add hotkey driver
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Sat, 28 Nov 2009 21:35:27 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, zhangfx@lemote.com, yanh@lemote.com, huhb@lemote.com, linux-input@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=r3OlSfdhsxmft6398W9Bw+wmLnRpdJ8txjQQRz9g3WU=; b=gwdbGuO9u93OptM6O3QfmEdPep09in53Ut2PXTtETghS6gzrXMqjDqPjgGwoK1TvUv 54MG/m5s1IV2UD1htdx+dcK4aG24CXzy3vymyPrsCV1zPZxIF0JYLZrbZmpRQqjPeqim Cxz32pv047X2V5mNRL8ryZB7kOevwP7paipQI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=g5AR/KWusRRgZHSv0W/lIm2AIqd0RGhBFlT4tLj34w/55qGHnivo/0wjEE54X57XfA dl1FRJ68sAdbybXUBRJ3NchuCCkO8HO4Vv/fcQgJgoZ6sXUQ5AOql+UfC7jtX8bh+Q8T ctinhdrZf7+YfAVPRhruofDhiz0d5o7x+1T14=
In-reply-to: <739db9c7b5bab429d0df5a7c68f301aa12f1402d.1259414649.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1259414649.git.wuzhangjin@gmail.com> <739db9c7b5bab429d0df5a7c68f301aa12f1402d.1259414649.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Nov 28, 2009 at 09:44:41PM +0800, Wu Zhangjin wrote:
>  
> +config YEELOONG_HOTKEY
> +     tristate "Hotkey Driver"
> +     depends on YEELOONG_VO
> +     select INPUT

I think this should be depend, not select. 

> +     select INPUT_EVDEV
> +     select SUSPEND

Does it break without SUSPEND? I am pretty sure that it will work fine
without EVDEV (however unlikely it is not present).

-- 
Dmitry

<Prev in Thread] Current Thread [Next in Thread>