linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 25 Nov 2009 16:19:52 +0000
Cc: Kevin Hickey <khickey@netlogicmicro.com>, Manuel Lauss <manuel.lauss@googlemail.com>, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1259165736.13740.7.camel@falcon.domain.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1259055230-15818-1-git-send-email-wuzhangjin@gmail.com> <f861ec6f0911240824u187347d6od5bfebc509a27d8d@mail.gmail.com> <20091124163006.GA11277@linux-mips.org> <1259160138.4675.14.camel@kh-d280-64> <1259165736.13740.7.camel@falcon.domain.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Nov 26, 2009 at 12:15:36AM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
> Date:   Thu, 26 Nov 2009 00:15:36 +0800
> To: Kevin Hickey <khickey@netlogicmicro.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>,
>       Manuel Lauss <manuel.lauss@googlemail.com>,
>       Linux-MIPS <linux-mips@linux-mips.org>
> Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
> Content-Type: text/plain; charset="UTF-8"
> 
> On Wed, 2009-11-25 at 08:42 -0600, Kevin Hickey wrote:
> > On Tue, 2009-11-24 at 16:30 +0000, Ralf Baechle wrote:
> > > On Tue, Nov 24, 2009 at 05:24:57PM +0100, Manuel Lauss wrote:
> > > 
> > > > On Tue, Nov 24, 2009 at 10:33 AM, Wu Zhangjin <wuzhangjin@gmail.com> 
> > > > wrote:
> > > > [...]
> > > > > This patch will only enable that option when the DEBUG_KERNEL is
> > > > > enabled.
> > > > 
> > > > How about making it independent from DEBUG_KERNEL altogether?  If find
> > > > it useful even without full debug info.
> > 
> > I agree with Manuel here.  I often build release kernels that benefit
> > from EARLY_PRINTK.  Why not make EARLY_PRINTK a selectable option in the
> > config?  Coupling it to DEBUG_KERNEL seems confusing. 
> 
> Hello,
> 
> Ralf have moved the EARLY_PRINTK to Kconfig.debug and removed the
> dependency on DEBUG_KERNEL in his -queue repository ;) Just as the X86
> and some other ARCHs does:
> 
> http://www.linux-mips.org/git?p=linux-queue.git
> 
> [...]
> +config EARLY_PRINTK
> +       bool "Early printk" if EMBEDDED
> +       depends on SYS_HAS_EARLY_PRINTK
> +       default y
> [...]
> 
> So, it is okay now, please ignore this patch ;)

Okay, dropped then.

Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>