On Thu, Nov 26, 2009 at 12:15:36AM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <firstname.lastname@example.org>
> Date: Thu, 26 Nov 2009 00:15:36 +0800
> To: Kevin Hickey <email@example.com>
> Cc: Ralf Baechle <firstname.lastname@example.org>,
> Manuel Lauss <email@example.com>,
> Linux-MIPS <firstname.lastname@example.org>
> Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
> Content-Type: text/plain; charset="UTF-8"
> On Wed, 2009-11-25 at 08:42 -0600, Kevin Hickey wrote:
> > On Tue, 2009-11-24 at 16:30 +0000, Ralf Baechle wrote:
> > > On Tue, Nov 24, 2009 at 05:24:57PM +0100, Manuel Lauss wrote:
> > >
> > > > On Tue, Nov 24, 2009 at 10:33 AM, Wu Zhangjin <email@example.com>
> > > > wrote:
> > > > [...]
> > > > > This patch will only enable that option when the DEBUG_KERNEL is
> > > > > enabled.
> > > >
> > > > How about making it independent from DEBUG_KERNEL altogether? If find
> > > > it useful even without full debug info.
> > I agree with Manuel here. I often build release kernels that benefit
> > from EARLY_PRINTK. Why not make EARLY_PRINTK a selectable option in the
> > config? Coupling it to DEBUG_KERNEL seems confusing.
> Ralf have moved the EARLY_PRINTK to Kconfig.debug and removed the
> dependency on DEBUG_KERNEL in his -queue repository ;) Just as the X86
> and some other ARCHs does:
> +config EARLY_PRINTK
> + bool "Early printk" if EMBEDDED
> + depends on SYS_HAS_EARLY_PRINTK
> + default y
> So, it is okay now, please ignore this patch ;)
Okay, dropped then.