linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency

To: Kevin Hickey <khickey@netlogicmicro.com>
Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Thu, 26 Nov 2009 00:15:36 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, Manuel Lauss <manuel.lauss@googlemail.com>, Linux-MIPS <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=96XwIroqYCUeChqUf4JKJs6LFllmJZNB/wFqDtGg0Xo=; b=VZRxpffJ1UB6IcVFXzDhBdkBP39nZpxHJEuI687VahWWbh/RgvnhBI+JsFE+ThZzNe YwFmxL/TkgeMW/4FGzgPf1cZZZEXaY06dONLX0LjeLIPtSGOow7xC2NThpeSqwXldWX4 RxolbGEjzDvM72FyFpQGuX2ZS3EbYstAFTpOQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=gchdp3p1+FatWbdPYCLeNWdwtXAIhyLgoVb91F7Rd9/OpDfe9e7SsUGis6IVfJRWde zXf66M0UGGOVBpQ/ot0Kkqa53R0E5cA8KlS/vOdG/3GiM2Xrj8jgjTGpQYJKE9POXNBl TB8M03l7eKTHB06iMoya8tA9gFDzM5aoeCNIg=
In-reply-to: <1259160138.4675.14.camel@kh-d280-64>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1259055230-15818-1-git-send-email-wuzhangjin@gmail.com> <f861ec6f0911240824u187347d6od5bfebc509a27d8d@mail.gmail.com> <20091124163006.GA11277@linux-mips.org> <1259160138.4675.14.camel@kh-d280-64>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Wed, 2009-11-25 at 08:42 -0600, Kevin Hickey wrote:
> On Tue, 2009-11-24 at 16:30 +0000, Ralf Baechle wrote:
> > On Tue, Nov 24, 2009 at 05:24:57PM +0100, Manuel Lauss wrote:
> > 
> > > On Tue, Nov 24, 2009 at 10:33 AM, Wu Zhangjin <wuzhangjin@gmail.com> 
> > > wrote:
> > > [...]
> > > > This patch will only enable that option when the DEBUG_KERNEL is
> > > > enabled.
> > > 
> > > How about making it independent from DEBUG_KERNEL altogether?  If find
> > > it useful even without full debug info.
> 
> I agree with Manuel here.  I often build release kernels that benefit
> from EARLY_PRINTK.  Why not make EARLY_PRINTK a selectable option in the
> config?  Coupling it to DEBUG_KERNEL seems confusing. 

Hello,

Ralf have moved the EARLY_PRINTK to Kconfig.debug and removed the
dependency on DEBUG_KERNEL in his -queue repository ;) Just as the X86
and some other ARCHs does:

http://www.linux-mips.org/git?p=linux-queue.git

[...]
+config EARLY_PRINTK
+       bool "Early printk" if EMBEDDED
+       depends on SYS_HAS_EARLY_PRINTK
+       default y
[...]

So, it is okay now, please ignore this patch ;)

Regards,
        Wu Zhangjin

> 
> =Kevin
> > 
> > DEBUG_INFO controlls the generation of ELF debug information.  DEBUG_KERNEL
> > only hides most of the debugging options.
> > 
> >   Ralf
> > 
> 



<Prev in Thread] Current Thread [Next in Thread>