linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: EARLY_PRINTK: Fixup of dependency
From: Kevin Hickey <khickey@netlogicmicro.com>
Date: Wed, 25 Nov 2009 08:42:18 -0600
Cc: Manuel Lauss <manuel.lauss@googlemail.com>, Wu Zhangjin <wuzhangjin@gmail.com>, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <20091124163006.GA11277@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1259055230-15818-1-git-send-email-wuzhangjin@gmail.com> <f861ec6f0911240824u187347d6od5bfebc509a27d8d@mail.gmail.com> <20091124163006.GA11277@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2009-11-24 at 16:30 +0000, Ralf Baechle wrote:
> On Tue, Nov 24, 2009 at 05:24:57PM +0100, Manuel Lauss wrote:
> 
> > On Tue, Nov 24, 2009 at 10:33 AM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > [...]
> > > This patch will only enable that option when the DEBUG_KERNEL is
> > > enabled.
> > 
> > How about making it independent from DEBUG_KERNEL altogether?  If find
> > it useful even without full debug info.

I agree with Manuel here.  I often build release kernels that benefit
from EARLY_PRINTK.  Why not make EARLY_PRINTK a selectable option in the
config?  Coupling it to DEBUG_KERNEL seems confusing. 

=Kevin
> 
> DEBUG_INFO controlls the generation of ELF debug information.  DEBUG_KERNEL
> only hides most of the debugging options.
> 
>   Ralf
> 


<Prev in Thread] Current Thread [Next in Thread>