Re: [PATCH] [MIPS] Move several variables from .bss to .init.data

[Dmitri Vorobiev <dmitri.vorobiev@gmail.com>]

On Mon, Nov 23, 2009 at 4:06 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 23 Nov 2009 15:43:27 +0200, Dmitri Vorobiev 
> <dmitri.vorobiev@gmail.com> wrote:
>> On Mon, Nov 23, 2009 at 3:26 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>> > On Mon, 23 Nov 2009 13:53:37 +0200, Dmitri Vorobiev 
>> > <dmitri.vorobiev@movial.com> wrote:
>> >> Several static uninitialized variables are used in the scope of
>> >> __init functions but are themselves not marked as __initdata.
>> >> This patch is to put those variables to where they belong and
>> >> to reduce the memory footprint a little bit.
>> >>
>> >> Also, a couple of lines with spaces instead of tabs were fixed.
>> >>
>> >> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
>> >
>> > NAK, at least for txx9 parts.  The struct mtd_partition arrays will be
>> > referenced by mtd map drivers via platform_data.
>>
>> You are right, thanks. What do you think about moving the variables to
>> file scope then?
>
> Well, why?  Does it make any check-scripts or something happy?

That's just looked somehow confusing to me that a variable defined in
the function scope was referenced from far outside this function, and
even when the function itself isn't valid anymore. Of course, there
are no technical disadvantage in that in itself.

Dmitri

>
> ---
> Atsushi Nemoto
>