linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] Move several variables from .bss to .init.data

To: dmitri.vorobiev@gmail.com
Subject: Re: [PATCH] [MIPS] Move several variables from .bss to .init.data
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 23 Nov 2009 23:06:16 +0900 (JST)
Cc: dmitri.vorobiev@movial.com, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <90edad820911230543i64f1e33fg86770f3ab2b6510b@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1258977217-25461-1-git-send-email-dmitri.vorobiev@movial.com> <20091123.222609.74748367.anemo@mba.ocn.ne.jp> <90edad820911230543i64f1e33fg86770f3ab2b6510b@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 23 Nov 2009 15:43:27 +0200, Dmitri Vorobiev <dmitri.vorobiev@gmail.com> 
wrote:
> On Mon, Nov 23, 2009 at 3:26 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> > On Mon, 23 Nov 2009 13:53:37 +0200, Dmitri Vorobiev 
> > <dmitri.vorobiev@movial.com> wrote:
> >> Several static uninitialized variables are used in the scope of
> >> __init functions but are themselves not marked as __initdata.
> >> This patch is to put those variables to where they belong and
> >> to reduce the memory footprint a little bit.
> >>
> >> Also, a couple of lines with spaces instead of tabs were fixed.
> >>
> >> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> >
> > NAK, at least for txx9 parts.  The struct mtd_partition arrays will be
> > referenced by mtd map drivers via platform_data.
> 
> You are right, thanks. What do you think about moving the variables to
> file scope then?

Well, why?  Does it make any check-scripts or something happy?

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>