linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] Move several variables from .bss to .init.data

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] [MIPS] Move several variables from .bss to .init.data
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 23 Nov 2009 13:46:33 +0000
Cc: dmitri.vorobiev@movial.com, linux-mips@linux-mips.org
In-reply-to: <20091123.222609.74748367.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1258977217-25461-1-git-send-email-dmitri.vorobiev@movial.com> <20091123.222609.74748367.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Nov 23, 2009 at 10:26:09PM +0900, Atsushi Nemoto wrote:

> On Mon, 23 Nov 2009 13:53:37 +0200, Dmitri Vorobiev 
> <dmitri.vorobiev@movial.com> wrote:
> > Several static uninitialized variables are used in the scope of
> > __init functions but are themselves not marked as __initdata.
> > This patch is to put those variables to where they belong and
> > to reduce the memory footprint a little bit.
> > 
> > Also, a couple of lines with spaces instead of tabs were fixed.
> > 
> > Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> > ---
> >  arch/mips/ar7/platform.c        |    2 +-
> >  arch/mips/sgi-ip22/ip22-eisa.c  |    4 ++--
> >  arch/mips/sgi-ip22/ip22-setup.c |    2 +-
> >  arch/mips/sgi-ip32/ip32-setup.c |    2 +-
> >  arch/mips/sni/setup.c           |    2 +-
> >  arch/mips/txx9/generic/setup.c  |    2 +-
> >  arch/mips/txx9/rbtx4939/setup.c |    4 ++--
> >  7 files changed, 9 insertions(+), 9 deletions(-)
> 
> NAK, at least for txx9 parts.  The struct mtd_partition arrays will be
> referenced by mtd map drivers via platform_data.

I'll drop the txx9 parts then.

> And for console option strings parts, I doubt these can be marked as
> __initdata.  Theoretically, the console driver might be a module,

No; if the driver is a module we don't offer console functionality.  Typical
example:

config SERIAL_8250
        tristate "8250/16550 and compatible serial support"
        select SERIAL_CORE
[...]
config SERIAL_8250_CONSOLE
        bool "Console on 8250/16550 and compatible serial port"
        depends on SERIAL_8250=y
        select SERIAL_CORE_CONSOLE

I think we consistently do this for all console drivers.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>