linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] Move several variables from .bss to .init.data

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] [MIPS] Move several variables from .bss to .init.data
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Date: Mon, 23 Nov 2009 15:43:27 +0200
Cc: dmitri.vorobiev@movial.com, linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=CTeZBBFnn9wrxExzmiKMCgjJGH4pw/wD9Y7CE9wvs3M=; b=N07Z5ilF/q5QOFhoX2Q5HA63MHAn2OcdvYrmCNpyaNdglJGGX1jyL5PSC60UD59Sz3 CJIEfI8hQN+abazE0qoUiPquLygqg2TqhttFqHM+I7psEOixjPTIKOQqINuSRdOVCFlN 2+cSU6bLW0XDau/Sw7p1zAUbeuVhg5wDpmwQ8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=KXvMgeJO1ecVlIVo6gJJq6PYF2y2sUeIDo1RR/hv8B97khlej2BjFVSr1YEYwRzHR+ 7BirK6kA8YVhTLTZKs1H8TC13AIf8VND4ggusQQrJpGM7+j/b9fEFIT0rPzRCMW7BAxR 7eNotqHq9HNyYhNuTVJZYKs8fIhs4hCn41wA4=
In-reply-to: <20091123.222609.74748367.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1258977217-25461-1-git-send-email-dmitri.vorobiev@movial.com> <20091123.222609.74748367.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Nov 23, 2009 at 3:26 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 23 Nov 2009 13:53:37 +0200, Dmitri Vorobiev 
> <dmitri.vorobiev@movial.com> wrote:
>> Several static uninitialized variables are used in the scope of
>> __init functions but are themselves not marked as __initdata.
>> This patch is to put those variables to where they belong and
>> to reduce the memory footprint a little bit.
>>
>> Also, a couple of lines with spaces instead of tabs were fixed.
>>
>> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
>> ---
>>  arch/mips/ar7/platform.c        |    2 +-
>>  arch/mips/sgi-ip22/ip22-eisa.c  |    4 ++--
>>  arch/mips/sgi-ip22/ip22-setup.c |    2 +-
>>  arch/mips/sgi-ip32/ip32-setup.c |    2 +-
>>  arch/mips/sni/setup.c           |    2 +-
>>  arch/mips/txx9/generic/setup.c  |    2 +-
>>  arch/mips/txx9/rbtx4939/setup.c |    4 ++--
>>  7 files changed, 9 insertions(+), 9 deletions(-)
>
> NAK, at least for txx9 parts.  The struct mtd_partition arrays will be
> referenced by mtd map drivers via platform_data.

You are right, thanks. What do you think about moving the variables to
file scope then?

Dmitri

>
> And for console option strings parts, I doubt these can be marked as
> __initdata.  Theoretically, the console driver might be a module,
>
> ---
> Atsushi Nemoto
>
>

<Prev in Thread] Current Thread [Next in Thread>