linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: Add a high resolution sched_clock() via cnt32_to_63

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH v2] MIPS: Add a high resolution sched_clock() via cnt32_to_63().
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 22 Nov 2009 19:06:16 +0100
Cc: Wu Zhangjin <wuzhangjin@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Thomas Gleixner <tglx@linutronix.de>, Michal Simek <monstr@monstr.eu>, linux-kernel@vger.kernel.org
In-reply-to: <4B0925BD.6070507@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <dae45f23b5d34f64fc60a445015e7dfe05aa0d07.1258875717.git.wuzhangjin@gmail.com> <20091122081328.GB24558@elte.hu> <4B0925BD.6070507@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-08-17)
* Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:

> Hello.
> 
> Ingo Molnar wrote:
> 
> >>+config HR_SCHED_CLOCK
> >>+   bool "High Resolution sched_clock()"
> >>+   depends on CSRC_R4K
> >>+   default n
> >>+   help
> >>+     This option enables the MIPS c0 count based high resolution
> >>+     sched_clock().
> >>+
> >>+     If you need a ns precision timestamp, You are recommended to enable
> >>+     this option. For example, If you are using the Ftrace subsystem to do
> 
>   s/If/if/
> 
> >>diff --git a/arch/mips/kernel/csrc-r4k.c b/arch/mips/kernel/csrc-r4k.c
> >>index e95a3cd..4e52cca 100644
> >>--- a/arch/mips/kernel/csrc-r4k.c
> >>+++ b/arch/mips/kernel/csrc-r4k.c
> >>@@ -6,10 +6,64 @@
> >>  * Copyright (C) 2007 by Ralf Baechle
> >>  */
> >> #include <linux/clocksource.h>
> >>+#include <linux/cnt32_to_63.h>
> >>+#include <linux/timer.h>
> >> #include <linux/init.h>
> >> #include <asm/time.h>
> >>+/*
> >>+ * MIPS' sched_clock implementation.
> >
> >s/MIPS'/MIPS's
> 
>   MIPS's is not really a proper English. :-)

AFAIK 'MIPS' is not the plural of 'MIP' (but an acronym ending with 
'S'), hence the possessive form would be MIPS's.

It doesnt matter much i guess ;-)

        Ingo

<Prev in Thread] Current Thread [Next in Thread>