Re: [PATCH -next] drivers/staging/sm7xx: add a new framebuffer driver

[Wu Zhangjin <wuzhangjin@gmail.com>]

On Sun, 2009-11-08 at 17:39 +0800, Wu wrote:
[...]
> +/* Jason (08/14/2009)
> + * suspend function, called when the suspend event is triggered
> + */
> +static int smtcfb_suspend(struct pci_dev *pdev, pm_message_t msg)
> +{

__maybe_unused is needed before smtcfb_suspend() to let gcc not complain
about "function defined but not used" when CONFIG_PM is disabled.

[...]
> +static int smtcfb_resume(struct pci_dev *pdev)
> +{

Here too.

> +static struct pci_driver smtcfb_driver = {
> +     .name = "smtcfb",
> +     .id_table = smtcfb_pci_table,
> +     .probe = smtcfb_pci_probe,
> +     .remove = __devexit_p(smtcfb_pci_remove),
> +#ifdef CONFIG_PM
> +     .suspend = smtcfb_suspend,
> +     .resume = smtcfb_resume,
> +#endif
> +};
> +

Best Regards,
        Wu Zhangjin