linux-mips
[Top] [All Lists]

Re: [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support

To: Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Thu, 12 Nov 2009 09:47:45 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, cpufreq@vger.kernel.org, Dave Jones <davej@redhat.com>, yanh@lemote.com, huhb@lemote.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=5T1Cx2jI02MtbsgLhuEeazvFfBHAwCv4b4rZKjiz1UA=; b=fFuwlGfsta5FBFQfNDwtrheKh2qOzIBGrQUcSbg0NOe1dwlecq0WnW9aQrL8o6IbA/ ER9+4F/cAU/AZf/C/Gk5al+7v5LKvi8GOoa+RhqSsaQA7KoeVmobloFsg+eeAXen+r9W 9CEm+USMcOBa4i5PGPAItAkwndLDjDoHDbgk8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=klIV/WtRk1amXOp4Gcf1ANFSwJW9Ytjfy8KS1lcziNXUaZNUrkYWu3fyw3Ys7rIg6+ Tg1tcUb6kXQfb1vURSTI3tTEwpmhaJKQaeKbkUGiiHns4ChxHqA9fKT0T0jDl/FbzLQk tsQeo2hs7Gkeac2Lxm4weKF7VF/45GmrSz8yI=
In-reply-to: <20091111182113.GB2690@comet.dominikbrodowski.net>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1257923011.git.wuzhangjin@gmail.com> <acbb780de66413230fb14272e6ce3bf12f9c24d3.1257923011.git.wuzhangjin@gmail.com> <20091111182113.GB2690@comet.dominikbrodowski.net>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
Hi,

On Wed, 2009-11-11 at 19:21 +0100, Dominik Brodowski wrote:
[...]
> > +   result = cpufreq_register_driver(&loongson2_cpufreq_driver);
> > +
> > +   if (!result && !nowait) {
> > +           saved_cpu_wait = cpu_wait;
> > +           cpu_wait = loongson2_cpu_wait;
> > +   }
> > +
> > +   cpufreq_register_notifier(&loongson2_cpufreq_notifier_block,
> > +                             CPUFREQ_TRANSITION_NOTIFIER);
> 
> IMO you should register the transition notifier before register_driver(),
> else there's a small window where a change may be initiate which is not
> notified...
> 

Will adjust them later, thanks!

Regards,
        Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>